Fix: #2397 Added System Language Option #2399
Conversation
SekhGulamMainuddin
changed the title
SekhGulamMainuddin
force-pushed
the
fixThemeIssueAndAddedSystemLanguageSupport
branch
from
8f71af4 to
2204a80
Compare
SekhGulamMainuddin
changed the title
SekhGulamMainuddin
force-pushed
the
fixThemeIssueAndAddedSystemLanguageSupport
branch
from
2204a80 to
ad5c434
Compare
|
@PratyushSingh07 can you please review my PR |
|
Any PR should solve a single issue. Are these two issues dependent on each other? If not then please segregate them |
app/src/main/java/org/mifos/mobile/ui/fragments/SettingsFragment.kt
Outdated
Show resolved
Hide resolved
| @@ -620,6 +622,7 @@ | |||
| </string-array> | |||
|
|
|||
| <string-array name="languages_value" translatable="false"> | |||
| <item>System_Language</item> | |||
There was a problem hiding this comment.
do we really need to add this option if we are changing the language dynamically? I mean the moment we set our mobile to follow a particular language it should be reflected in our app at that very instance.
There was a problem hiding this comment.
Yes, we need it because if we are dependent on the System's Language then having a System Language value will be helpful. And sometimes if the System's Language is not supported in our App then English is made as Default. I have attached the videos for it also on the top.
This is also similar to the app theme preference on System Theme, Dark Theme, and Light Theme.
…anguage Option
SekhGulamMainuddin
force-pushed
the
fixThemeIssueAndAddedSystemLanguageSupport
branch
from
ad5c434 to
74d2b90
Compare
@PratyushSingh07 Sorry for it. I formatted the code now and added the changes as you said. Please review it. |
|
@PratyushSingh07 can you please re-review this? |
SekhGulamMainuddin
deleted the
fixThemeIssueAndAddedSystemLanguageSupport
branch
SekhGulamMainuddin
restored the
fixThemeIssueAndAddedSystemLanguageSupport
branch
SekhGulamMainuddin
changed the title
Fixes #2397
Video Recordings:
System Language Option Added
System.Language.Options.added.mp4
If System Language is Not Present then English is Default
Here I switched to Punjabi which is not supported by the App so it is showing English by Default.
If.System.Language.Not.Present.then.English.is.Default.mp4