Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix#2356 Guarantor Type Selection Fixed #2373

Conversation

SekhGulamMainuddin
Copy link
Contributor

@SekhGulamMainuddin SekhGulamMainuddin commented Oct 13, 2023

Fixes #2356

Removed the choicea and choiceB Options since they had no usage and were added explicitly in the code. Currently it has three Guarantor Type i.e. CUSTOMER, STAFF and EXTERNAL

Please add #hacktoberfest on merge.

VID_20231013231445.mp4

@PratyushSingh07
Copy link
Collaborator

Add a screen recording, screenshot wont be helpful in this case

@SekhGulamMainuddin
Copy link
Contributor Author

Add a screen recording, screenshot wont be helpful in this case

added

@SekhGulamMainuddin SekhGulamMainuddin force-pushed the fixGuarantorTypeSelection branch from f8fdddb to 6ce2077 Compare October 13, 2023 18:56
@SekhGulamMainuddin
Copy link
Contributor Author

@therajanmaurya please merge my PR.
Please add hacktoberfest tags on merge.

@SekhGulamMainuddin
Copy link
Contributor Author

@PratyushSingh07 please review this PR

Copy link
Collaborator

@PratyushSingh07 PratyushSingh07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please format your code , you can use ctrl+alt+L if you are on windows

@SekhGulamMainuddin SekhGulamMainuddin force-pushed the fixGuarantorTypeSelection branch from 6ce2077 to a4e2dfd Compare October 14, 2023 07:39
@SekhGulamMainuddin
Copy link
Contributor Author

@PratyushSingh07 I have added the changes of formatting the code. Please review it.

@SekhGulamMainuddin SekhGulamMainuddin marked this pull request as ready for review October 14, 2023 09:56
@PratyushSingh07
Copy link
Collaborator

PratyushSingh07 commented Oct 14, 2023

LGTM @therajanmaurya , we can merge this

@therajanmaurya therajanmaurya merged commit 2383baf into openMF:development Oct 18, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App crashes when selecting Guarantor Type
3 participants