fixes: snackbar error messages on registration and password change #2364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PratyushSingh07
requested changes
Oct 12, 2023
app/src/main/java/org/mifos/mobile/viewModels/RegistrationViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mifos/mobile/viewModels/UpdatePasswordViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mifos/mobile/ui/fragments/UpdatePasswordFragment.kt
Outdated
Show resolved
Hide resolved
|
Please change the commit message from |
srishti-R
force-pushed
the
snackbar-error-message-fixes
branch
from
200b0b6 to
a279fd1
Compare
srishti-R
force-pushed
the
snackbar-error-message-fixes
branch
from
a279fd1 to
20f949a
Compare
PratyushSingh07
requested changes
Oct 14, 2023
app/src/main/java/org/mifos/mobile/ui/fragments/RegistrationFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mifos/mobile/ui/fragments/UpdatePasswordFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mifos/mobile/viewModels/RegistrationViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mifos/mobile/viewModels/RegistrationViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mifos/mobile/viewModels/RegistrationViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mifos/mobile/viewModels/UpdatePasswordViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mifos/mobile/viewModels/UpdatePasswordViewModel.kt
Outdated
Show resolved
Hide resolved
srishti-R
force-pushed
the
snackbar-error-message-fixes
branch
from
20f949a to
2816b19
Compare
|
LGTM @srishti-R , great job |
|
@therajanmaurya review and merge this as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2363 #2361
Please Add Screenshots If there are any UI changes.
Previously the entire JSON of the error was shown in snackbar conveying nothing meaningful. I have extracted the actual error message that comes within the error body and that is displayed as an error message.
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
AndroidStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.