-
Notifications
You must be signed in to change notification settings - Fork 711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: unit tests for repositories & viewmodes using turbine #2305
Closed
PratyushSingh07
wants to merge
7
commits into
openMF:development
from
PratyushSingh07:unit-tests-fix
Closed
fix: unit tests for repositories & viewmodes using turbine #2305
PratyushSingh07
wants to merge
7
commits into
openMF:development
from
PratyushSingh07:unit-tests-fix
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PratyushSingh07
changed the title
fix: unit tests for repositories with turbine
fix: unit tests for repositories & viewmodes using turbine
Aug 25, 2023
I have added the below job to run the unit tests in our master yml file test:
name: Unit Tests
runs-on: ubuntu-latest
steps:
- name: Checking out repository
uses: actions/checkout@v3
- name: Test App
run: ./gradlew test
- name: Upload Test Report
uses: actions/[email protected]
if: failure()
with:
name: test-reports
path: app/build/reports/ |
I have also added job for checkstyle to ensure that it meets the code quality standards checkstyle:
name: Checkstyle
runs-on: ubuntu-latest
steps:
- name: Checking out Repository
uses: actions/checkout@v3
- name: Checkstyle
run: ./gradlew checkstyle
- name: Upload Checkstyle Reports
uses: actions/[email protected]
with:
name: checkstyle-reports
path: app/build/reports/ |
PratyushSingh07
force-pushed
the
unit-tests-fix
branch
from
August 26, 2023 09:11
0e9bca9
to
8d35896
Compare
could you review this @jawidMuhammadi !! |
Any update on this @jawidMuhammadi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply the
AndroidStyle.xml
style template to your code in Android Studio.Run the unit tests with
./gradlew check
to make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.