refactor #2534: migrated review loan application screen to compose

openMF · Apr 7, 2024 · 6bece26 · 6bece26
1 parent be3583a
commit 6bece26
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/app/src/main/java/org/mifos/mobile/ui/loan_review/ReviewLoanApplicationScreen.kt b/app/src/main/java/org/mifos/mobile/ui/loan_review/ReviewLoanApplicationScreen.kt
@@ -68,10 +68,6 @@ fun ReviewLoanApplicationScreen(
             ReviewLoanApplicationContent(modifier = Modifier.padding(16.dp), data = data, submit = submit)
 
             when (uiState) {
-                is ReviewLoanApplicationUiState.Initial -> {
-                    // Data shown in UI
-                }
-
                 is ReviewLoanApplicationUiState.Loading -> {
                     MifosProgressIndicator(modifier = Modifier.fillMaxSize().background(MaterialTheme.colorScheme.background.copy(0.8f)))
                 }
@@ -90,6 +86,8 @@ fun ReviewLoanApplicationScreen(
                     }
                     navigateBack(true)
                 }
+
+                is ReviewLoanApplicationUiState.ReviewLoanUiReady -> Unit
             }
         }
     }
@@ -119,7 +117,7 @@ fun ErrorComponent(
 class UiStatesParameterProvider : PreviewParameterProvider<ReviewLoanApplicationUiState> {
     override val values: Sequence<ReviewLoanApplicationUiState>
         get() = sequenceOf(
-            ReviewLoanApplicationUiState.Initial,
+            ReviewLoanApplicationUiState.ReviewLoanUiReady,
             ReviewLoanApplicationUiState.Error(throwable = Throwable()),
             ReviewLoanApplicationUiState.Loading,
             ReviewLoanApplicationUiState.Success(loanState = LoanState.CREATE)

diff --git a/app/src/main/java/org/mifos/mobile/ui/loan_review/ReviewLoanApplicationViewModel.kt b/app/src/main/java/org/mifos/mobile/ui/loan_review/ReviewLoanApplicationViewModel.kt
@@ -49,7 +49,7 @@ class ReviewLoanApplicationViewModel @Inject constructor(
             disbursementDate = loansPayload.expectedDisbursementDate,
             loanId = loanId ?: 0
         )
-        _reviewLoanApplicationUiState.value = ReviewLoanApplicationUiState.Initial
+        _reviewLoanApplicationUiState.value = ReviewLoanApplicationUiState.ReviewLoanUiReady
     }
 
 
@@ -69,7 +69,7 @@ class ReviewLoanApplicationViewModel @Inject constructor(
 }
 
 sealed class ReviewLoanApplicationUiState {
-    data object Initial : ReviewLoanApplicationUiState()
+    data object ReviewLoanUiReady : ReviewLoanApplicationUiState()
     data object Loading : ReviewLoanApplicationUiState()
     data class Error(val throwable: Throwable) : ReviewLoanApplicationUiState()
     data class Success(val loanState: LoanState) : ReviewLoanApplicationUiState()