AWS: Fix SimpleMakefile when command is wrapped #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrSerth
added
bug
This comment was marked as off-topic.
This comment was marked as off-topic.
MrSerth
force-pushed
the
fix_aws_makefile
branch
from
b8c3c0c
to
0306092
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #695 +/- ##
==========================================
+ Coverage 76.32% 76.38% +0.05%
==========================================
Files 43 43
Lines 3688 3688
==========================================
+ Hits 2815 2817 +2
+ Misses 637 635 -2
Partials 236 236 ☔ View full report in Codecov by Sentry. |
Dome-GER
changed the title
Dome-GER
approved these changes
Sep 30, 2024
Previously, a command such as the following would fail due to the additional quotes used:
env CODEOCEAN=true /bin/bash -c "unset \"\${!AWS@}\" && make test CLASS_NAME=\"HalloWeltTest2\" FILENAME=\"HalloWeltTest2.java\""
Dome-GER
force-pushed
the
fix_aws_makefile
branch
from
0306092
to
a7299ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a command such as the following would fail due to the additional quotes used:
env CODEOCEAN=true /bin/bash -c "unset \"\${!AWS@}\" && make test CLASS_NAME=\"HalloWeltTest2\" FILENAME=\"HalloWeltTest2.java\""