Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/#593 incomplete debug message #688

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Conversation

mpass99
Copy link
Collaborator

@mpass99 mpass99 commented Sep 12, 2024

Closes #593

@mpass99 mpass99 self-assigned this Sep 12, 2024
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.

Project coverage is 76.14%. Comparing base (78fce4c) to head (a023903).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/nomad/sentry_debug_writer.go 82.35% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #688      +/-   ##
==========================================
- Coverage   76.18%   76.14%   -0.04%     
==========================================
  Files          43       43              
  Lines        3645     3660      +15     
==========================================
+ Hits         2777     2787      +10     
- Misses        633      636       +3     
- Partials      235      237       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@MrSerth MrSerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you! As written in #593, I've tested the code with 5_000 repetitions locally and wasn't able to reproduce the issue any longer. ♾️💪

When you think that the debug output I posted in the issue matches your assumption, I would recommend merging 👍

@mpass99
Copy link
Collaborator Author

mpass99 commented Sep 13, 2024

Thanks to your reproduction and logs, I could verify that indeed the debug message was split in between.

by buffering a message when the message does not contain both start and end of a debug message.
@mpass99 mpass99 force-pushed the fix/#593-incomplete-debug-message branch from 6982bf0 to a023903 Compare September 13, 2024 14:01
@mpass99 mpass99 enabled auto-merge (rebase) September 13, 2024 14:01
@mpass99 mpass99 merged commit 7706533 into main Sep 13, 2024
10 checks passed
@mpass99 mpass99 deleted the fix/#593-incomplete-debug-message branch September 13, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exec debug message could not be read completely
2 participants