Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prohibiting Nomad Job recreation with delay in between #680

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

mpass99
Copy link
Collaborator

@mpass99 mpass99 commented Sep 5, 2024

by not purging a job once its allocation stops (and maybe would be replaced).

Related to #673

Scenario: Deleting and Creating the environment before each restart
Before PR
1 - 0/5
2 - 0/5
3 - 0/5
4 - 0/5
5 - 0/5

After PR
1 - 5/5
2 - 5/5
3 - 5/5 (one slow recreation)
4 - 5/5
5 - 5/5

by not purging a job once its allocation stops (and maybe would be replaced).
@mpass99 mpass99 requested a review from MrSerth September 5, 2024 10:27
@mpass99 mpass99 self-assigned this Sep 5, 2024
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.19%. Comparing base (43e6a3e) to head (9bea900).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #680   +/-   ##
=======================================
  Coverage   76.19%   76.19%           
=======================================
  Files          43       43           
  Lines        3592     3592           
=======================================
  Hits         2737     2737           
  Misses        625      625           
  Partials      230      230           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@MrSerth MrSerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! 🪴

@mpass99 mpass99 merged commit e56b870 into main Sep 5, 2024
12 checks passed
@mpass99 mpass99 deleted the fix/#673-superfluous-purging branch September 5, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants