Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve deprecation warnings for Docker #39

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Resolve deprecation warnings for Docker #39

wants to merge 2 commits into from

Conversation

MrSerth
Copy link
Member

@MrSerth MrSerth commented Sep 5, 2024

Creating the Docker containers previously resulted in the following two deprecation warnings being issued:

 2 warnings found (use docker --debug to expand):
 - MaintainerDeprecated: Maintainer instruction is deprecated in favor of using label (line 2)
 - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 28)

This PR fixes these deprecation warnings and adds

@MrSerth
Fix LegacyKeyValueFormat deprecation
3c7da55 
Environment variables should use an equal sign (=) after the variable name.
@MrSerth
Use image-spec annotations for Docker images
ef2f646 
Also fixes a MaintainerDeprecated warning.
@MrSerth MrSerth added enhancement docker Pull requests that update Docker dependencies labels Sep 5, 2024
@MrSerth MrSerth self-assigned this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dome-GER Dome-GER Awaiting requested review from Dome-GER

Assignees

@MrSerth MrSerth

Labels
docker Pull requests that update Docker dependencies enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MrSerth