Add Solid Cable adapter for ActionCable #1660
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## rails_72 #1660 +/- ##
=========================================
Coverage 94.22% 94.22%
=========================================
Files 126 126
Lines 3050 3050
=========================================
Hits 2874 2874
Misses 176 176 ☔ View full report in Codecov by Sentry. |
MrSerth
force-pushed
the
rails_72
branch
2 times, most recently
from
3c3b549
to
cb770de
Compare
MrSerth
force-pushed
the
solid_cable
branch
from
74d892c
to
c53bf4a
Compare
MrSerth
force-pushed
the
solid_cable
branch
from
c53bf4a
to
4846c88
Compare
MrSerth
force-pushed
the
solid_cable
branch
from
4846c88
to
a5c2413
Compare
MrSerth
force-pushed
the
solid_cable
branch
from
a5c2413
to
3dcdff4
Compare
Switching the adapter is not expected to make any noticeable difference and is in line with CodeOcean. The new Solid Cable adapter is also shipping with Rails 8 by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActionCable got introduced with Rails 7.2 for CodeHarbor. Switching the adapter is not expected to make any noticeable difference and is in line with CodeOcean. The new Solid Cable adapter is also shipping with Rails 8 by default.