Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ [#170] add unique constraint for filter model #227

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

✨ [#170] add unique constraint for filter model #227

wants to merge 2 commits into from

Conversation

annashamray
Copy link
Contributor

fixes #170

@annashamray
Copy link
Contributor Author

I haven't added validator to the API because I couldn't reproduce this in the API POST and PUT requests:
If you have duplicated filter keys, then JSON object would have duplicated keys and only the last key would be kept and processed

@annashamray annashamray changed the title ✨ [#170] add unique constraint for filter ✨ [#170] add unique constraint for filter model Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenbal stevenbal Awaiting requested review from stevenbal

@SonnyBA SonnyBA Awaiting requested review from SonnyBA

@danielmursa-dev danielmursa-dev Awaiting requested review from danielmursa-dev

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

As a developer I want to make unique constraint on (filter_group, key) in the Filter model
1 participant
@annashamray