Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Zenburn, and 2 OCaml extensions #131

Merged
merged 2 commits into from
Aug 31, 2020
Merged

Conversation

edwintorok
Copy link
Contributor

No description provided.

@spoenemann
Copy link
Collaborator

Thanks for the contribution!

hc-zenburn-vscode has no license. I opened kyeongmincho/hc-zenburn-vscode#4 to address this, but we have to wait until that is done before we can add it to Open VSX.

vscode-reasonml says in its README that it's currently unmaintained. Do you think it is still useful?

Generally it would be good to add checkout properties with the respective release tags to all new entries. This ensures that we build from exactly the sources that were used for the version we want to install.

@edwintorok
Copy link
Contributor Author

Indeed vscode-reasonml is deprecated and doesn't work with recent versions of OCaml anymore, I removed it from this PR.
There is an alternative linked from its github page, and I opened an issue to get it added to open-vsx.org: jaredly/reason-language-server#465. It is not as simple as adding to package.json because package.json is missing some fields.

@edwintorok
Copy link
Contributor Author

A license file has been added for hc-zenburn-vscode, and I've added a checkout property for ocamllabs.ocaml-platform, so hopefully this PR is good to go now? (hc-zenburn-vscode has no tags, so I could only add a hash as checkout, not sure if that'd be useful)

@spoenemann
Copy link
Collaborator

@drzix chose GPL-3.0 for hc-zenburn-vscode. Unfortunately that license is not compatible with requirements of the Eclipse Foundation at this moment, see #49 (comment).

@edwintorok could you remove that extension from this PR? We might be able to include GPL licensed extensions at some point, for now we should stick with the current requirements.

@edwintorok
Copy link
Contributor Author

I intended to use hc-zenburn-vscode with Codium which is MIT licensed and therefore compatible with GPL3. It'd be nice if open-vsix had a way of accepting GPL3 extensions for the purposes of Codium (and hide it from Eclipse if it has to).

Anyway I've replaced that plugin with another one that is MIT licensed (it is not the high-contrast version).

@spoenemann spoenemann merged commit 71c33bb into open-vsx:master Aug 31, 2020
@spoenemann
Copy link
Collaborator

It'd be nice if open-vsix had a way of accepting GPL3 extensions for the purposes of Codium

I agree. We might get back to this in case the requirements will change.

@jankeromnes
Copy link
Collaborator

jankeromnes commented Sep 4, 2020

Update: Auto-publishing worked! 🎉

It'd be nice if open-vsix had a way of accepting GPL3 extensions for the purposes of Codium

I agree as well. FYI, we're currently investigating a solution that could potentially allow any open-source license onto OpenVSX. If it works, you can expect more news on that in a few weeks.

tennox pushed a commit to tennox/publish-extensions that referenced this pull request Jan 21, 2022
* Add ocamllabs.ocaml-platform (ISC licensed)
* Add ryanolsonx.zenburn (MIT)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants