Support protovalidate validation #259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0cd3157.
andrewparmet
changed the title
andrewparmet
commented
Dec 16, 2024
Comment on lines
+67
to
+75
| val output = command(runner).runCommand(projectRoot.toPath()) | ||
| println(output.stderr) | ||
|
|
||
| assertThat(output.stderr).contains("CONFORMANCE SUITE PASSED") | ||
| val matches = " (\\d+) unexpected failures".toRegex().findAll(output.stderr).toList() | ||
| // the current implementation runs two conformance suites | ||
| assertThat(matches).hasSize(2) | ||
| matches.forEach { assertThat(it.groupValues[1].toInt()).isEqualTo(0) } | ||
| assertThat(output.exitCode).isEqualTo(0) |
There was a problem hiding this comment.
Just some cleanup.
| @@ -0,0 +1,283 @@ | |||
| standard_constraints/ignore_empty: | |||
There was a problem hiding this comment.
Whelp, gotta start somewhere. We were "fully" conformant until 0.8.0.
andrewparmet
commented
Dec 16, 2024
| - proto2/wrapped/uint32/valid | ||
| - proto2/wrapped/uint64/invalid | ||
| - proto2/wrapped/uint64/valid | ||
| - proto3/bool/invalid |
There was a problem hiding this comment.
I'm most concerned about the proto3 tests below this point since we don't support proto2 or edition 2023.
ogolberg
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the validator eagerly converts the protokt message to a protobuf DynamicMessage. With bufbuild/protovalidate-java#132, this can change to supply a wrapper around the protokt message that only converts as requested by the validator.
Not sure if this module belongs at the top level or in third-party. In that case, maybe the gRPC modules also belong in third-party. For example, supposing protokt one day supports the Connect protocol, that would also go in third-party, but it feels like a sibling to gRPC.
Fixes #207.