rename core classes #251
Merged
rename core classes #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewparmet
commented
May 8, 2024
| @file:JvmName("AnyUtil") | ||
| @file:JvmName("Anies") |
There was a problem hiding this comment.
andrewparmet
force-pushed
the
rename-core-classes
branch
from
726292e to
7e45b70
Compare
This reverts commit 7e45b70.
ogolberg
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
messageSizeis a function so it can't conflict with a fieldmessage_sizeI renamed them Writer and Encoder to try to highlight that, but I don't love that name. I just can't think of better. Open to suggestions. Other options are Writer and Reader; pb-and-k uses Marshaller and Unmarshaller; Javaland's equivalents are the coded streams.used Reader and Writer