Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stability shields to markdown snippet generation #90

Merged
merged 5 commits into from
Apr 9, 2024

Conversation

jsuereth
Copy link
Contributor

@jsuereth jsuereth commented Apr 8, 2024

Adds stability shield and cleans up some formatting differences between weaver and current "head" build-tools.

  • Partially wires in is_local vs. is_full logic.
  • Add reusable stabiltiy shield method.
  • Add stability to all necessary tables (metrics, enums + attributes)
  • Update tests.

jsuereth added 3 commits April 8, 2024 08:33
- Add stability badges where required
- Initial buggy implementation of is_local.
- Update tests
- Remove linage-based is_full implementation.
@jsuereth jsuereth requested a review from lquerel as a code owner April 8, 2024 21:22
Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 70.83333% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 63.6%. Comparing base (17ff1c6) to head (1deb55f).

❗ Current head 1deb55f differs from pull request most recent head 45cbf55. Consider uploading reports for the commit 45cbf55 to get more accurate results

Files Patch % Lines
crates/weaver_semconv_gen/src/gen.rs 68.8% 14 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main     #90     +/-   ##
=======================================
+ Coverage   63.4%   63.6%   +0.1%     
=======================================
  Files         54      54             
  Lines       3209    3235     +26     
=======================================
+ Hits        2037    2058     +21     
- Misses      1172    1177      +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lquerel lquerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsuereth jsuereth merged commit 40ba701 into open-telemetry:main Apr 9, 2024
13 checks passed
@jsuereth jsuereth deleted the pr-stability-shields branch April 9, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants