Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new flatten method so we can generate notes in semconv #80

Merged

Conversation

jsuereth
Copy link
Contributor

@jsuereth jsuereth commented Apr 4, 2024

This is actually an interesting issue where minijinja does NOT support mutating existing lists via append, but jinja does.

For now, we just use [notes, [newitem]] | flatten to simulate append as a workaround.

This is actually an interesting issue where minijinja does NOT support mutating existing lists via `append`, but jinja does.

For now, we just use `[notes, [newitem]] | flatten` to simulate append as a workaround.
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 63.2%. Comparing base (ec0d0c7) to head (1cecd05).

❗ Current head 1cecd05 differs from pull request most recent head 48fdc6c. Consider uploading reports for the commit 48fdc6c to get more accurate results

Files Patch % Lines
crates/weaver_forge/src/lib.rs 14.2% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main     #80     +/-   ##
=======================================
- Coverage   63.3%   63.2%   -0.2%     
=======================================
  Files         54      54             
  Lines       3202    3209      +7     
=======================================
+ Hits        2030    2031      +1     
- Misses      1172    1178      +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsuereth jsuereth marked this pull request as ready for review April 4, 2024 21:24
- Cannot add templates to weaver.yaml without losing all defaults (something ODD happens here)
- Cannot run weaver-forge tests on windows (line endings, file-path printing is OS specific)
@jsuereth jsuereth merged commit 6775571 into open-telemetry:main Apr 4, 2024
13 checks passed
@jsuereth jsuereth deleted the template-features-for-semconv-demo branch April 4, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants