Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(template): Make kebab-case filter working with digits in the middle of a word #106

Merged
merged 7 commits into from
Apr 16, 2024

Conversation

lquerel
Copy link
Contributor

@lquerel lquerel commented Apr 12, 2024

"K8S" | kebab-case => "k8s"

@lquerel lquerel added the enhancement New feature or request label Apr 12, 2024
@lquerel lquerel self-assigned this Apr 12, 2024
@lquerel lquerel requested a review from jsuereth as a code owner April 12, 2024 18:26
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.6%. Comparing base (cc89370) to head (a5dd451).

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #106     +/-   ##
=======================================
+ Coverage   65.4%   65.6%   +0.2%     
=======================================
  Files         56      56             
  Lines       3292    3315     +23     
=======================================
+ Hits        2153    2176     +23     
  Misses      1139    1139             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsuereth
Copy link
Contributor

FYI - I found this issue is the same for the TitleCase filter too.

@lquerel
Copy link
Contributor Author

lquerel commented Apr 15, 2024

@jsuereth Please review. That should be ok now.

@jsuereth jsuereth merged commit 3412c3e into open-telemetry:main Apr 16, 2024
20 checks passed
@lquerel lquerel deleted the fix-kebak-case-issue branch April 17, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants