Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Browser Web Vitals Event #1940

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Karlie-777
Copy link

Fixes #

Changes

Please provide a brief description of the changes here.

Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.

Merge requirement checklist

@Karlie-777 Karlie-777 requested review from a team as code owners February 26, 2025 22:17
@Karlie-777 Karlie-777 marked this pull request as draft February 26, 2025 23:45
@Karlie-777 Karlie-777 marked this pull request as ready for review February 26, 2025 23:45
name: browser.web_vital
brief: >
This event describes the website performance metrics introduced by Google, See [web vitals](https://web.dev/vitals).
body:
Copy link
Contributor

@breedx-splk breedx-splk Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to see a comment here to clarify that this is temporary or that this will actually be an attribute. That way readers do not expect to find content in the actual body.

Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants