CPython runtime garbage collections metrics #1931
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xrmx
commented
Feb 24, 2025
xrmx
commented
Feb 24, 2025
xrmx
commented
Feb 24, 2025
xrmx
commented
Feb 24, 2025
|
cc @open-telemetry/python-approvers @open-telemetry/opentelemetry-python-contrib-approvers |
emdneto
approved these changes
Feb 28, 2025
lmolkova
reviewed
Mar 5, 2025
|
|
||
| - id: metric.cpython.gc.collected | ||
| type: metric | ||
| metric_name: cpython.gc.collected |
There was a problem hiding this comment.
With cpython.gc.collected name it can be confusing to have number of object and the amount of memory (if we ever report it).
It'd be great to be specific in the metric name, e.g. call it
Suggested change
| metric_name: cpython.gc.collected | |
| metric_name: cpython.gc.collected.objects |
There was a problem hiding this comment.
I can do that but we don't have any stats in bytes, this 3 metrics per gc generation are everything we have from gc.get_stats()
| - ref: cpython.gc.generation | ||
| requirement_level: required | ||
|
|
||
| - id: metric.cpython.gc.uncollectable |
There was a problem hiding this comment.
similar to the previous comment, it'd be great to have explicit name like
Suggested change
| - id: metric.cpython.gc.uncollectable | |
| - id: metric.cpython.gc.uncollectable.objects |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1930
Changes
This adds 3 new metrics to track CPython runtime garbage collector work.
Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.
Merge requirement checklist
[chore]