Add test cases for DB query parsing and sanitization #1923
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #984
Opening this PR to start a discussion for how we want to format test cases for database query parsing and sanitization.
Each test case includes the following fields
name
identifying the test casesql
statement representing the inputsanitized
versions of the inputIN
clauses MAY be collapsed. So, bothIN (?)
andIN (?,?,?)
are valid.summary
is whatdb.query.summary
should equaloperation
is whatdb.operation.name
should equalcollection
is whatdb.collection.name
should equaldialects
that the test case targetsFor this first iteration I would like to settle on the format for presenting these test cases. In follow ups we can expand the test cases and also handle additional idiosyncrasies of other dialects.