Adding span for invoke agent #1900
Open
+168
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gyliu513 this needs rebase after the experimental -> development rename |
lmolkova
reviewed
Feb 13, 2025
gyliu513
force-pushed
the
invoke
branch
3 times, most recently
from
1af7a29 to
b704514
Compare
|
@lmolkova I think I have addressed all comments here, can you help review again? Thanks! |
lmolkova
reviewed
Mar 4, 2025
| |---|---|---|---|---|---| | ||
| | [`gen_ai.operation.name`](/docs/attributes-registry/gen-ai.md) | string | The name of the operation being performed. [1] | `chat`; `text_completion`; `embeddings` | `Required` |  | | ||
| | [`gen_ai.system`](/docs/attributes-registry/gen-ai.md) | string | The Generative AI product as identified by the client or server instrumentation. [2] | `openai` | `Required` |  | | ||
| | [`gen_ai.agent.description`](/docs/attributes-registry/gen-ai.md) | string | Free-form description of the GenAI agent provided by the application. | `Helps with math problems`; `Generates fiction stories` | `Conditionally Required` If provided by the application. |  | |
There was a problem hiding this comment.
I don't think it's common to have agent description of name around when invoking a service-side agent.
- bedrock only has agent id - https://docs.aws.amazon.com/bedrock/latest/APIReference/API_agent-runtime_InvokeAgent.html
- openai assistants only have id - https://platform.openai.com/docs/api-reference/runs/createThreadAndRun
- azure ai agents only have id - https://learn.microsoft.com/en-us/azure/ai-services/agents/overview#what-is-an-ai-agent
so I think we need to update requirement level on the name and description to something like recommended: when available
There was a problem hiding this comment.
sorry, this comment is about invoke_agent
lmolkova
reviewed
Mar 4, 2025
docs/gen-ai/gen-ai-agent-spans.md
Outdated
|
|
||
| The `gen_ai.operation.name` SHOULD be `invoke_agent`. | ||
|
|
||
| The **span name** SHOULD be `invoke_agent {gen_ai.agent.name}`. |
There was a problem hiding this comment.
since gen_ai.agent.name is rarely available for remote agents, I think we need to change it to
Suggested change
| The **span name** SHOULD be `invoke_agent {gen_ai.agent.name}`. | |
| The **span name** SHOULD be `invoke_agent {gen_ai.agent.name}` if `gen_ai.agent.name` is readily available. When `gen_ai.agent.name` is not available, it SHOULD be `invoke_agent`. |
lmolkova
reviewed
Mar 4, 2025
| |---|---|---|---|---|---| | ||
| | [`gen_ai.operation.name`](/docs/attributes-registry/gen-ai.md) | string | The name of the operation being performed. [1] | `chat`; `text_completion`; `embeddings` | `Required` |  | | ||
| | [`gen_ai.system`](/docs/attributes-registry/gen-ai.md) | string | The Generative AI product as identified by the client or server instrumentation. [2] | `openai` | `Required` |  | | ||
| | [`gen_ai.agent.description`](/docs/attributes-registry/gen-ai.md) | string | Free-form description of the GenAI agent provided by the application. | `Helps with math problems`; `Generates fiction stories` | `Conditionally Required` If provided by the application. |  | |
There was a problem hiding this comment.
is there any reason we don't have gen_ai.agent.id on create agent span?
There was a problem hiding this comment.
Usually, the agent id should be generated when the agent is invoked. When the agent was created, the end user can specified the agent name, but for agent id, it seems need to be a run time attribute, comments?
Signed-off-by: Guangya Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1842 #1924
Changes
Please provide a brief description of the changes here.
Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.
Merge requirement checklist
[chore]