Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make replication controller metrics consistent with resource attributes #1848

Merged
merged 4 commits into from
Feb 3, 2025

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Jan 29, 2025

Changes

Follow up from #1742 to follow the naming of K8s api for resources. This PR applies the following changes:

k8s.replication_controller.desired_pods -> k8s.replicationcontroller.desired_pods
k8s.replication_controller.available_pods -> k8s.replicationcontroller.available_pods

Merge requirement checklist

@ChrsMark ChrsMark requested review from a team as code owners January 29, 2025 09:19
@ChrsMark ChrsMark self-assigned this Jan 29, 2025
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have some work to do to establish guidance around when to concat words with _ and when to concat with nothing, but I think that can take place outside of this PR

model/k8s/deprecated/metrics-deprecated.yaml Outdated Show resolved Hide resolved
model/k8s/deprecated/metrics-deprecated.yaml Outdated Show resolved Hide resolved
@ChrsMark
Copy link
Member Author

ChrsMark commented Feb 3, 2025

@open-telemetry/semconv-k8s-approvers could you give a +1 on this so as we can merge it?

@AlexanderWert AlexanderWert merged commit 360499a into open-telemetry:main Feb 3, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants