Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yamlize existing session events #1845

Merged
merged 13 commits into from
Jan 30, 2025

Conversation

breedx-splk
Copy link
Contributor

@breedx-splk breedx-splk commented Jan 28, 2025

Fixes #1676, fixes #1133

Changes

This adds the formal yaml definitions for session.start and session.end events. They existed previously only in markdown. Now the markdown is generated.

Merge requirement checklist

@breedx-splk breedx-splk requested review from a team as code owners January 28, 2025 23:33
@breedx-splk
Copy link
Contributor Author

No clue if the changelog should be updated for this. Pretty sure schema-next doesn't get events yet?

model/session/events.yaml Outdated Show resolved Hide resolved
model/session/events.yaml Outdated Show resolved Hide resolved
model/session/events.yaml Outdated Show resolved Hide resolved
@lmolkova lmolkova added the Skip Changelog Label to skip the changelog check label Jan 29, 2025
@lmolkova
Copy link
Contributor

No clue if the changelog should be updated for this. Pretty sure schema-next doesn't get events yet?

I added skip-changelog label since there is nothing new being defined. Feel fee to override me though

@trask
Copy link
Member

trask commented Jan 29, 2025

I added skip-changelog label since there is nothing new being defined. Feel fee to override me though

I think it's moving body fields to attributes (breaking?)

@lmolkova lmolkova removed the Skip Changelog Label to skip the changelog check label Jan 29, 2025
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@breedx-splk
Copy link
Contributor Author

can you add a change log file? (see https://github.com/open-telemetry/semantic-conventions/tree/main/.chloggen)

You're too fast! 🙃

Anyway, I'm unable to run the verification step, so I'm just going to yolo push the changelog file.

$ make chlog-validate
/Users/jplumb/code/semantic-conventions/internal/tools/bin/chloggen validate --config .chloggen/config.yaml
/Users/jplumb/code/semantic-conventions/internal/tools/bin/chloggen: /Users/jplumb/code/semantic-conventions/internal/tools/bin/chloggen: cannot execute binary file
make: *** [chlog-validate] Error 126

@trask trask merged commit 84cfd0c into open-telemetry:main Jan 30, 2025
15 checks passed
@trask
Copy link
Member

trask commented Jan 30, 2025

let's go @breedx-splk! next?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Review and yamlify session events Tracking issue for events yaml
3 participants