-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yamlize existing session events #1845
Yamlize existing session events #1845
Conversation
No clue if the changelog should be updated for this. Pretty sure schema-next doesn't get events yet? |
I added skip-changelog label since there is nothing new being defined. Feel fee to override me though |
I think it's moving body fields to attributes (breaking?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add a change log file? (see https://github.com/open-telemetry/semantic-conventions/tree/main/.chloggen)
You're too fast! 🙃 Anyway, I'm unable to run the verification step, so I'm just going to yolo push the changelog file.
|
Co-authored-by: Trask Stalnaker <[email protected]>
let's go @breedx-splk! next? |
Fixes #1676, fixes #1133
Changes
This adds the formal yaml definitions for
session.start
andsession.end
events. They existed previously only in markdown. Now the markdown is generated.Merge requirement checklist
[chore]