model/profile: add frame.type for Erlang #1735
Open
+29
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianl
force-pushed
the
profile-frame-type-beam
branch
from
3c72a30 to
d2d8a1b
Compare
Extend the list of known frame types with a value for Erlang. Signed-off-by: Florian Lehner <[email protected]>
florianl
force-pushed
the
profile-frame-type-beam
branch
from
d2d8a1b to
542d56a
Compare
florianl
commented
Jan 10, 2025
| - id: beam | ||
| brief: > | ||
| [Erlang](https://en.wikipedia.org/wiki/BEAM_(Erlang_virtual_machine)) | ||
| value: "beam" |
There was a problem hiding this comment.
Please see this discussion https://github.com/open-telemetry/semantic-conventions/pull/1188/files#r1722087658 on why beam was chosen as value here rather than erlang (for the language).
There was a problem hiding this comment.
/cc @tsloughter @bryannaegele and other @open-telemetry/erlang-approvers in case they have any thoughts
|
cc @open-telemetry/profiling-approvers |
lmolkova
approved these changes
Jan 17, 2025
| - id: beam | ||
| brief: > | ||
| [Erlang](https://en.wikipedia.org/wiki/BEAM_(Erlang_virtual_machine)) | ||
| value: "beam" |
There was a problem hiding this comment.
/cc @tsloughter @bryannaegele and other @open-telemetry/erlang-approvers in case they have any thoughts
Co-authored-by: Liudmila Molkova <[email protected]>
felixge
approved these changes
Jan 20, 2025
trask
approved these changes
Jan 21, 2025
|
moving to draft and back, to see if that will give profiling approvers green checkmark |
|
one more try (closing and re-opening) 🤷♂️ |
|
ah, will fix... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Please provide a brief description of the changes here.
FYI @open-telemetry/profiling-maintainers
Merge requirement checklist
[chore]