-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change azure_
and az.
to azure.
across all conventions
#1698
base: main
Are you sure you want to change the base?
Conversation
/cc @trask, @mattmccleary, @rajkumar-rangaraj, @cijothomas, @lzchen @RohitRanjanMS, @OsvaldoRosado, @reyang if the have any context on how breaking they expect it to be. |
azure_
to az.
in enum valuesazure_
to az.
in cloud.platform
enum values on
Thanks, @lmolkova . Functions is still in its early stages with respect to OTel, and I don't see any issues with this proposal. |
We do have azure resource detector that use some of these values although the component itself is experimental. In azmon exporter, we currently do not map resource attributes to telemetry custom dimensions BUT we do populate OTELRESOURCE custom metric which is populated with the resource attribute information. I believe this feature is in preview as well so probably not an issue to make breaking changes. |
azure_
to az.
in cloud.platform
enum values onazure_
to az.
in cloud.platform
enum values
930a4e6
to
32b06a1
Compare
azure_
to az.
in cloud.platform
enum valuesazure_
and az.
to azure.
across all conventions
brief: "The unique identifier of the service request. It's generated by the Azure service and returned with the response." | ||
examples: | ||
- "00000000-0000-0000-0000-000000000000" | ||
- id: az.namespace | ||
- id: azure.resource.namespace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatives:
azure.provider.namespace
azure.resource.provider.namespace
- precise, but too longazure.rp.namespace
- this acronym is likely to be MS-internal thing
@@ -5,15 +5,15 @@ groups: | |||
brief: > | |||
This document defines generic attributes for Azure SDK. | |||
attributes: | |||
- id: az.service_request_id | |||
- id: azure.service.request.id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatives:
azure.server.request.id
(there is alsoazure.client.request.id
counterpart not documented here) - this aligns with semconv better, butservice
gives a nuance that it's generated by the Azure service, whileserver
is used in semconv more the context of user app
- id: azure_app_service | ||
value: 'azure_app_service' | ||
value: 'azure_app_service.app_service' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops
Azure-specific attributes/signals use
azure.
prefix to denote they belong toazure
namespace.We should
cloud.platform
enum values:azure_aks
->azure.aks
azure_app_service
->azure.app_service
azure_container_apps
->azure.container_apps
azure_container_instances
->azure.container_instances
azure_functions
->azure.functions
azure_openshift
->azure.openshift
azure_vm
->azure.vm
gen_ai.system
enum values:az.ai.inference
->azure.ai.inference
az.ai.openai
-> ->azure.ai.openai
az.namespace
->azure.resource.namespace
az.service_request_id
->azure.service.request.id
az.resource.log
->azure.resource.log
Related to #1684 (comment), #608, #1708, #1613
PS: We should do similar renames for AWS and GCP,
cloud.provider
->cloud.provider.name
,cloud.platform
-> ?Merge requirement checklist
[chore]