Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark code.* attributes as release candidate #1599

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

SylvainJuge
Copy link
Contributor

@SylvainJuge SylvainJuge commented Nov 20, 2024

Relates to #1377

Changes

This PR marks the non-deprecated code.* attributes as release candidate.

Merge requirement checklist

Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's mark as release candidate first, we don't have a great way to do that yet, but you can follow pattern used in #1101

@SylvainJuge SylvainJuge changed the title mark code.* attributes as stable mark code.* attributes as release candidate Nov 21, 2024
@lmolkova
Copy link
Contributor

I support this change.

A few things we should also update:

@SylvainJuge SylvainJuge mentioned this pull request Nov 27, 2024
3 tasks
@SylvainJuge
Copy link
Contributor Author

I have opened #1624 for the naming changes suggestions, it contains a list of all the repositories that would be impacted.

@github-actions github-actions bot added the enhancement New feature or request label Mar 3, 2025
@SylvainJuge
Copy link
Contributor Author

Now that #1624 and #1677 are now merged, we should be able to move this forward and mark the attributes as release-candidate, so I've refreshed the PR and it should now be ready to review.

@SylvainJuge SylvainJuge marked this pull request as ready for review March 3, 2025 13:25
@SylvainJuge SylvainJuge requested a review from a team as a code owner March 3, 2025 13:25
@SylvainJuge SylvainJuge requested review from a team as code owners March 3, 2025 13:25
Copy link
Contributor

@jsuereth jsuereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but would like to see @task's proposed changes merged

Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we first have a release with code.namespace marked as deprecated?

Otherwise, we are just removing code.namespace and this changelog entry does not make sense: https://github.com/SylvainJuge/semantic-conventions/blob/0acdb7241e968c434d0fe279a6bfd375642d13ce/.chloggen/1646.yaml

@lmolkova
Copy link
Contributor

lmolkova commented Mar 5, 2025

@pellared it's already deprecated

deprecated: Value should be included in `code.function.name` which is expected to be a fully-qualified name.

this PR only removed the reference to it from the attribute group and didn't change anything about the attribute definition. That's a common practice we follow in semconv and it's not breaking code-gen.

Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per

That's a common practice we follow in semconv and it's not breaking code-gen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Needs More Approval
Development

Successfully merging this pull request may close these issues.

5 participants