-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize db.query.parameter.<key>
to db.operation.parameter.<key>
#1559
Generalize db.query.parameter.<key>
to db.operation.parameter.<key>
#1559
Conversation
6628583
to
b9f7d83
Compare
b9f7d83
to
b06f056
Compare
@lquerel this is another data point on schema transformation limitations. Do we have an existing tracking issue I can update to include it? |
@lmolkova, we have two GitHub issues related to this topic:
It would be great to get your feedback on one or both of these issues, especially in light of the discussions in the current PR.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to (eventually) support this in Schema URL. For now, marking this breaking in changelog seems the only thing we can really do.
IIRC - the plan is to have a "2.0" like migration period for DB instrumentation right?
Generalize
db.query.parameter.<key>
todb.operation.parameter.<key>
, so that it can be used also for stored procedure parameters as well (and maybe other kinds of operations?)Note: I don't think(?) schema transforms support attribute type
template[string]