Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GenAI events - yamlify body definitions and cosmetic examples improvements #1469

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

GenAI events - yamlify body definitions and cosmetic examples improvements #1469

wants to merge 9 commits into from

Conversation

lmolkova
Copy link
Contributor

@lmolkova lmolkova commented Oct 11, 2024 •
edited
Loading

  • Adds yaml definitions for GenAI events in preparation for Render events with bodies #1464
  • Updates examples to be more concise and readable, fixes small inconsistencies, adds diagrams.

Merge requirement checklist

@lmolkova lmolkova requested review from a team as code owners October 11, 2024 01:58
@lmolkova lmolkova changed the title GenAI event examples - cosmetic improvements GenAI events - yamlify body definitions and cosmetic examples improvements Oct 11, 2024
@lmolkova lmolkova requested a review from a team as a code owner October 18, 2024 22:32
lmolkova
lmolkova commented Oct 21, 2024
View reviewed changes
model/gen-ai/events.yaml
requirement_level:
conditionally_required: if available and not equal to `assistant`.
- id: tool_calls
type: map # TODO: it's an array
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: this is blocker - need to release new weaver that supports it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trentm trentm trentm left review comments

@nirga nirga nirga approved these changes

@xrmx xrmx xrmx approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
area:gen-ai
Projects
GenAI Client Semantic Conventions
Status: In Progress
Semantic Conventions Triage
Status: In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lmolkova @xrmx @trentm @nirga @AlexanderWert