Skip to content

Remove unused multi callback #2107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Remove unused multi callback #2107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions opentelemetry-sdk/src/metrics/pipeline.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ type GenericCallback = Arc<dyn Fn() + Send + Sync>;
struct PipelineInner {
aggregations: HashMap<Scope, Vec<InstrumentSync>>,
callbacks: Vec<GenericCallback>,
multi_callbacks: Vec<Option<GenericCallback>>,
}

impl fmt::Debug for PipelineInner {
Expand Down Expand Up @@ -109,11 +108,6 @@ impl SdkProducer for Pipeline {
cb();
}

for mcb in inner.multi_callbacks.iter().flatten() {
// TODO consider parallel multi callbacks.
mcb();
}

rm.resource = self.resource.clone();
if inner.aggregations.len() > rm.scope_metrics.len() {
rm.scope_metrics
Expand Down
Loading