-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade hyper and otel dependencies #97
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #97 +/- ##
=======================================
+ Coverage 52.3% 56.4% +4.1%
=======================================
Files 38 39 +1
Lines 4967 5441 +474
=======================================
+ Hits 2598 3074 +476
+ Misses 2369 2367 -2 ☔ View full report in Codecov by Sentry. |
@kcking-openai thanks for the PR. Regarding resource, while it was removed from SpanData, SpanExporter::set_resource() method was introduced for one time setting of resource in Exporter. Default implementation was added for it in the SpanExporter trait so that custom exporters don't break. You may want to implement the |
Also, you have to sign the easyCLA before the PR can be approved. |
a9c06b5
to
8727213
Compare
Deleted resource publishing as `resource` is no longer a field on SpanData.
Thank you @lalitb, I have completed the CLA and pushed a fix for the lint. If you would like an alternative solution to the |
And I just pushed a fix for some lints that had broken in a couple unrelated directories. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kcking-openai. This looks good. Will publish a release shortly.
Changes
Upgrade otel and hyper dependencies, change HttpClient example to hyper over unix socket.
I removed writing the resource for every span, as the field was removed from
SpanData
.Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes