Skip to content

chore: leverage fallback resolver for MSRV check #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

gruebel
Copy link
Member

@gruebel gruebel commented May 15, 2025

Changes

Rust 1.84 introduced a new resolver type which is MSRV aware

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@gruebel gruebel requested a review from a team as a code owner May 15, 2025 20:52
Copy link

codecov bot commented May 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.9%. Comparing base (c48871a) to head (1f91ac3).

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #263   +/-   ##
=====================================
  Coverage   50.9%   50.9%           
=====================================
  Files         64      64           
  Lines       8506    8506           
=====================================
  Hits        4331    4331           
  Misses      4175    4175           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

# Conflicts:
#	.github/workflows/ci.yml
Copy link
Contributor

@hdost hdost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have typically tried to reserve bumping of dependencies for when it's necessary by our dependencies. By changing the msrv check this negates that.

@gruebel
Copy link
Member Author

gruebel commented May 17, 2025

We have typically tried to reserve bumping of dependencies for when it's necessary by our dependencies. By changing the msrv check this negates that.

not sure I follow, but there is no dependency upgrade or something like that. Rust 1.84 added a new resolver, which is MSRV aware so it chooses automatically the latest version, which fits the given MSRV. This means you don't need to maintain a separate patch mechanism for making sure you don't update to a version with a higher MSRV need. Here it is nicely explained https://doc.rust-lang.org/cargo/reference/resolver.html#rust-version

The MSRV check still works the same and this is proof it works as intended otherwise it would have failed with complaining about the dependencies needing a higher MSRV.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants