-
Notifications
You must be signed in to change notification settings - Fork 61
chore: leverage fallback resolver for MSRV check #263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #263 +/- ##
=====================================
Coverage 50.9% 50.9%
=====================================
Files 64 64
Lines 8506 8506
=====================================
Hits 4331 4331
Misses 4175 4175 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
# Conflicts: # .github/workflows/ci.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have typically tried to reserve bumping of dependencies for when it's necessary by our dependencies. By changing the msrv check this negates that.
not sure I follow, but there is no dependency upgrade or something like that. Rust 1.84 added a new resolver, which is MSRV aware so it chooses automatically the latest version, which fits the given MSRV. This means you don't need to maintain a separate patch mechanism for making sure you don't update to a version with a higher MSRV need. Here it is nicely explained https://doc.rust-lang.org/cargo/reference/resolver.html#rust-version The MSRV check still works the same and this is proof it works as intended otherwise it would have failed with complaining about the dependencies needing a higher MSRV. |
Changes
Rust 1.84 introduced a new resolver type which is MSRV aware
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes