fix: user-events logs exporter - alternate build pattern #262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #262 +/- ##
=====================================
Coverage 50.9% 50.9%
=====================================
Files 64 63 -1
Lines 8506 8500 -6
=====================================
+ Hits 4331 4332 +1
+ Misses 4175 4168 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lalitb
approved these changes
May 16, 2025
|
|
||
| use crate::logs::exporter::UserEventsExporter; | ||
|
|
||
| /// Processes and exports logs to User Events. |
There was a problem hiding this comment.
Suggested change
| /// Processes and exports logs to User Events. | |
| /// Processes and exports logs to user_events. |
| /// Processes and exports logs to User Events. | ||
| /// | ||
| /// This processor exports logs without synchronization. | ||
| /// It is specifically designed for the User Events exporter, where |
There was a problem hiding this comment.
Suggested change
| /// It is specifically designed for the User Events exporter, where | |
| /// It is specifically designed for the user_events exporter, where |
| } | ||
|
|
||
| impl Processor { | ||
| /// Creates a builder for configuring a User Events Processor |
There was a problem hiding this comment.
Suggested change
| /// Creates a builder for configuring a User Events Processor | |
| /// Creates a builder for configuring a user_events Processor |
| } | ||
| } | ||
|
|
||
| /// Builder for configuring and constructing a User Events Processor |
There was a problem hiding this comment.
Suggested change
| /// Builder for configuring and constructing a User Events Processor | |
| /// Builder for configuring and constructing a user_events Processor |
utpilla
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bundle options directly into processor, as users are ultimately going to build a processor.
Expose Processor, builder in public API - users still don't know about reentrantprocessor - they get back something
impl LogProcessor.Populate PartB.name from event_name, if available.
Hard code "Log" as user_event's event_name
(TODO: Add support for a callback for user-event event_name.)
TODO: Add custom error Struct.