-
Notifications
You must be signed in to change notification settings - Fork 61
feat: [WIP] contribute tower-otel-http-metrics middleware crate #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: [WIP] contribute tower-otel-http-metrics middleware crate #248
Conversation
…tion-tower/examples to workspace for now
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #248 +/- ##
=======================================
- Coverage 50.4% 49.4% -1.1%
=======================================
Files 60 61 +1
Lines 7629 7784 +155
=======================================
Hits 3851 3851
- Misses 3778 3933 +155 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I believe above two would be pre-requisite for this PR, rest can be discussed and handled in subsequent PRs. The MIT license is compatible with Apache 2.0, so changing the license should be fine, while keeping the attributing to original:
Also, if there are any questions specific to license/copyright. more clarity can be obtained by raising the question as issue in the |
https://github.com/open-telemetry/opentelemetry-rust-contrib/tree/main/opentelemetry-instrumentation-actix-web Consider following structure from this, for examples etc. |
Could this be considered as normal code contribution? Or this is to be treated as a code-donation? @lalitb do you know ? |
LICENSE and NOTICE updated in the form @lalitb suggested. @cijothomas Re:
I don't see much structure to follow there considering how much more is in the examples for this package - what I have for examples is a much larger and comprehensive superset of what's in the actix-web directory. |
|
||
#[tokio::main] | ||
async fn main() { | ||
let exporter = opentelemetry_otlp::MetricExporter::builder() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for instrumentation's docs, it's easy to use the stdout exporter. It'll be hard to maintain proper OTLP example for each instrumentations.
@@ -0,0 +1,21 @@ | |||
apiVersion: 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add a readme.md file to the development folder explaining how to leverage the docker-compose, and the grafana dashboards?
I am also not sure how much detailed example we want to maintain per instrumentation. it may makes sense to move some of these to common examples, as they are applicable to any web apps...
Changes
This contribution is a work in progress, just wanted to get it kicked off to have eyes on it.
I was invited to contribute this by @cijothomas, and have received approval from Grafana to contribute work hours towards maintaining this.
Currently the source code lives at https://github.com/francoposa/tower-otel-http-metrics and the crate is at https://crates.io/crates/tower-otel-http-metrics.
There are some various cleanup tasks here - any advice or direction is appreciated!
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes