Fix stackdriver resources #149
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds newly added k8s related resource mappings
The key was removed from https://cloud.google.com/trace/docs/trace-labels and the UI says the service name is not derived from service.name which is also the semconv key.
The new API requires one to use set_resource for each exporter. The added set_resource for the stackdriver exporter used a different Arc than used inside each ExporterContext. The resource stored in ExporterContext is used during the request creation, and thus there was no way to pass along the correct resource attributes.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #149 +/- ##
=======================================
- Coverage 54.2% 54.1% -0.1%
=======================================
Files 42 42
Lines 6276 6271 -5
=======================================
- Hits 3402 3397 -5
Misses 2874 2874 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Design discussion issue (if applicable) #
Changes
While preparing for a new
opentelemtry-stackdriverrelease and updating the dependencies it seems a bug was introduced.The new API stores resource attributes directly in the exporter. By adding this two instances of
RwLock<Resource>were introduced, making it impossible to set the resource (usingset_resource) as theExporterContextuses a different pointer.This fixes the issue and also updates resource attribute key mappings to the latest version (added k8s mappings and removed outdated service.name mapping).
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes