Use unstable sort to group traces in DD exporter. #144
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stable sort is not required for grouping, while unstable gives slightly better performance according to
opentelemetry-datadog/benches/datadog_exporter.rs
Changes
Changed sort implementation to perform grouping by trace_id to use unstable sort (not preserving order of already sorted items). It has slightly better performance that stable sort while not violating contract of DD api.
Before:
before
after
CHANGELOG.md
files updated for non-trivial, user-facing changes