Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opentelemetry 0.27 #131

Closed

Conversation

psandana
Copy link
Contributor

Changes

Update opentelemetry_etw_logs to use opentelemetry and opentelemetry_sdk versions 0.27

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@psandana psandana requested a review from a team as a code owner November 25, 2024 13:05
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 55.4%. Comparing base (559fe64) to head (c510146).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-etw-logs/src/logs/exporter.rs 50.0% 2 Missing ⚠️
opentelemetry-etw-logs/src/logs/converters.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #131     +/-   ##
=======================================
- Coverage   55.4%   55.4%   -0.1%     
=======================================
  Files         39      39             
  Lines       6105    6107      +2     
=======================================
  Hits        3385    3385             
- Misses      2720    2722      +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@psandana
Copy link
Contributor Author

Seems overlapping with #130 .

@cijothomas
Copy link
Member

Seems overlapping with #130 .

yes, closing this in favor of that.!

@cijothomas cijothomas closed this Nov 27, 2024
@psandana psandana deleted the opentelemetry-etw-logs-0.27 branch December 3, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants