Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh generated code in opentelemetry-stackdriver #102

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

fiadliel
Copy link
Contributor

Send and Sync in code generated by tonic 0.12.2 is fully qualified as std::marker::Send and std::marker::Sync.

Changes

Refreshes generated code in opentelemetry-stackdriver to fix "generated_code_is_fresh" test.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

`Send` and `Sync` in code generated by tonic 0.12.2 is fully qualified as
`std::marker::Send` and `std::marker::Sync`.
@fiadliel fiadliel requested a review from a team August 28, 2024 17:20
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We had similar issue with otel-rust proto generated files :)

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 56.4%. Comparing base (56a6f45) to head (5a84f56).
Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
...ry-stackdriver/src/proto/devtools/cloudtrace/v2.rs 0.0% 1 Missing ⚠️
opentelemetry-stackdriver/src/proto/logging/v2.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #102     +/-   ##
=======================================
+ Coverage   52.3%   56.4%   +4.1%     
=======================================
  Files         38      39      +1     
  Lines       4967    5441    +474     
=======================================
+ Hits        2598    3074    +476     
+ Misses      2369    2367      -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lalitb lalitb merged commit d7d9af5 into open-telemetry:main Aug 28, 2024
7 of 8 checks passed
@fiadliel fiadliel deleted the fiadliel/push-wqzpmzymlvrp branch August 28, 2024 17:53
@lalitb
Copy link
Member

lalitb commented Sep 10, 2024

@fiadliel proto generation is failing, can you pls check once.

@fiadliel
Copy link
Contributor Author

@fiadliel proto generation is failing, can you pls check once.

Filed #108 - further (but unimportant) divergence. As I suggested in the PR, maybe this should remain on #[ignore], and have a separate scheduled divergence test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants