Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: metrics sdk support for schema_url and attributes #1719

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

xuan-cao-swi
Copy link
Contributor

Descriptions

Closes #1708
Closes #1709

Copy link
Contributor

@kaylareopelle kaylareopelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that this adds the plumbing needed to attach a schema URL and attributes to a meter.

However, I'm concerned about adding the schema URL at this time. I don't think we have the semantic conventions setup to support schemas. I'm not very versed in this OTel concept, so I might be misunderstanding how it's supposed to work.

The telemetry schemas spec says there are three parties coupled by the schema: OTel semantic conventions, telemetry sources and telemetry consumers. The presence of a schema URL may benefit a telemetry consumer (AKA a vendor backend that uses this value to deliver a customer experience), but we're missing the features needed to link a schema URL with semantic conventions emitted by our telemetry sources, which seems like a large gap to me.

In #1651, we're looking at updating the conventions that can be emitted, but I don't believe there is any link to schema URL to determine what conventions are emitted.

@robbkidd, I feel like you have the best grasp on semantic conventions here, and I hope that extends to schema URLs too. What are your thoughts on the SDK's readiness to add support for schema URLs? If we're not ready, what would we need to accomplish to become ready?

@xuan-cao-swi
Copy link
Contributor Author

xuan-cao-swi commented Sep 17, 2024

... but we're missing the features needed to link a schema URL with semantic conventions emitted by our telemetry sources, which seems like a large gap to me.

Totally agree. I was thinking just put there as a placeholder for spec compliance.

Copy link
Contributor

👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this pull request will be closed eventually by the stale bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To do
Development

Successfully merging this pull request may close these issues.

MeterProvider#meter accepts attributes Add support for schema_url
2 participants