ci: Add Tests For Ruby 3.3 #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielvalentin
requested review from
fbogsany,
mwear,
robertlaurin,
dazuma,
ericmustin,
ahayworth,
plantfansam,
robbkidd,
simi and
kaylareopelle
as code owners
arielvalentin
force-pushed
the
add-ruby-3.3
branch
from
c9d2739 to
5ce9c04
Compare
arielvalentin
commented
Jan 6, 2024
arielvalentin
commented
Jan 6, 2024
arielvalentin
force-pushed
the
add-ruby-3.3
branch
2 times, most recently
from
0ee841d to
c9c3ec2
Compare
Ruby 3.3 is out so this PR adds actions to test against it. One this to note is that bigcommerce/gruf does not yet support Ruby 3.3. Once bigcommerce/gruf#197 is merged I will update the test suite to include gruf again.
arielvalentin
force-pushed
the
add-ruby-3.3
branch
from
c9c3ec2 to
d4cfe71
Compare
kreopelle
approved these changes
Jan 10, 2024
|
@kreopelle did you mean to approve as your alter ego @kaylareopelle ? |
splittingred
reviewed
Feb 5, 2024
| @@ -59,6 +59,14 @@ jobs: | |||
| runs-on: ${{ matrix.os }} | |||
| steps: | |||
| - uses: actions/checkout@v4 | |||
| - name: "Test Ruby 3.3" | |||
| # BLOCKED BY: https://github.com/bigcommerce/gruf/pull/197 | |||
There was a problem hiding this comment.
Hey @arielvalentin - this has now been addressed and released, in connection with the grpc 1.61 release: https://rubygems.org/gems/gruf/versions/2.19.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 3.3 is out so this PR adds actions to test against it.
One this to note is that
bigcommerce/grufdoes not yet support Ruby 3.3. Once bigcommerce/gruf#197 is merged I will update the test suite to include gruf again.