-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: access rdkafka message headers with strings instead of symbols #650
Conversation
c36b910
to
f8d2036
Compare
@Ruto8 Would you kindly take a look at this failing test? |
f8d2036
to
6dc0a55
Compare
@arielvalentin thank you for pointing this out. Unfortunately, the tests pass locally for me. I'm able to access the span, as expected. Can there be some differences between CI and local setup here? Is it possible it's a flaky test? |
Did you try running the test with the seed option that's failing?
Or running the test in a loop to see if it's non-deterministic? Something like for i in {1..20}; do
bundle exec rake test
done
|
👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the |
👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the |
For context, we're using both
rdkafka-ruby
andopentelemetry-ruby-contrib
and we get a lot of warnings like this in the logs:I tracked it down to this line from
rdkafka-ruby
, where it seems they have deprecated accessing headers with Symbols.In this PR, I removed the specific getter set to
symbol_key_getter
for the rdkafka consumer patch. This is also similar to what is done with ruby-kafka.I believe the getter will default to
text_map_getter
, so we don't have to explicitly set it here.