test: Update que Appraisals #1256
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest version of the gem now supports Rails 7.2
Active Record 7.2+ are only compatible with que 2.4.1+
kaylareopelle
commented
Nov 21, 2024
Comment on lines
+14
to
+18
| if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('3.1.0') | ||
| gem 'activerecord', '~> 7.2.0' | ||
| else | ||
| gem 'activerecord' | ||
| end |
There was a problem hiding this comment.
Without this, we'd skip testing on Rails 7.2 and jump straight to Rails 8.0. Que made a change to support Rails 7.2 in 2.4.1, but our instrumentation didn't need to change.
Since these tests are for our instrumentation and not necessarily for activerecord compatibility with que, I'm not sure we need the condition. Thoughts?
|
👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the |
kaylareopelle
requested review from
fbogsany,
mwear,
robertlaurin,
dazuma,
ericmustin,
arielvalentin,
ahayworth,
plantfansam,
robbkidd,
simi,
xuan-cao-swi and
a team
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version of the gem now supports Rails 7.2 and Rails 8.0
Resolves: #1110