Cache GraphQL attributes

open-telemetry · Feb 15, 2024 · cfc84f7 · cfc84f7
1 parent 5d40562
commit cfc84f7
Showing 1 changed file with 65 additions and 14 deletions.
diff --git a/instrumentation/graphql/lib/opentelemetry/instrumentation/graphql/tracers/graphql_tracer.rb b/instrumentation/graphql/lib/opentelemetry/instrumentation/graphql/tracers/graphql_tracer.rb
@@ -86,24 +86,75 @@ def config
           end
 
           def attributes_for(key, data)
-            attributes = {}
             case key
-            when 'execute_field', 'execute_field_lazy'
-              attributes['graphql.field.parent'] = data[:owner]&.graphql_name # owner is the concrete type, not interface
-              attributes['graphql.field.name'] = data[:field]&.graphql_name
-              attributes['graphql.lazy'] = key == 'execute_field_lazy'
-            when 'authorized', 'authorized_lazy'
-              attributes['graphql.type.name'] = data[:type]&.graphql_name
-              attributes['graphql.lazy'] = key == 'authorized_lazy'
-            when 'resolve_type', 'resolve_type_lazy'
-              attributes['graphql.type.name'] = data[:type]&.graphql_name
-              attributes['graphql.lazy'] = key == 'resolve_type_lazy'
+            when 'execute_field'
+              field_attr_cache = data[:query].context.namespace(:otel_attrs)[:execute_field_attrs] ||= attr_cache do |field|
+                {
+                  'graphql.field.parent' => field.owner.graphql_name,
+                  'graphql.field.name' => field.graphql_name,
+                  'graphql.lazy' => false
+                }.freeze
+              end
+              field_attr_cache[data[:field]]
+            when 'execute_field_lazy'
+              lazy_field_attr_cache = data[:query].context.namespace(:otel_attrs)[:execute_field_lazy_attrs] ||= attr_cache do |field|
+                {
+                  'graphql.field.parent' => field.owner.graphql_name,
+                  'graphql.field.name' => field.graphql_name,
+                  'graphql.lazy' => true
+                }.freeze
+              end
+              lazy_field_attr_cache[data[:field]]
+            when 'authorized'
+              authorized_attr_cache = data[:context].namespace(:otel_attrs)[:authorized_attrs] ||= attr_cache do |type|
+                {
+                  'graphql.type.name' => type.graphql_name,
+                  'graphql.lazy' => false
+                }.freeze
+              end
+              authorized_attr_cache[data[:type]]
+            when 'authorized_lazy'
+              authorized_lazy_attr_cache = data[:context].namespace(:otel_attrs)[:authorized_lazy_attrs] ||= attr_cache do |type|
+                {
+                  'graphql.type.name' => type.graphql_name,
+                  'graphql.lazy' => true
+                }
+              end
+              authorized_lazy_attr_cache[data[:type]]
+            when 'resolve_type'
+              resolve_type_attr_cache = data[:context].namespace(:otel_attrs)[:resolve_type_attrs] ||= attr_cache do |type|
+                {
+                  'graphql.type.name' => type.graphql_name,
+                  'graphql.lazy' => false
+                }
+              end
+              resolve_type_attr_cache[data[:type]]
+            when 'resolve_type_lazy'
+              resolve_type_lazy_attr_cache = data[:context].namespace(:otel_attrs)[:resolve_type_lazy_attrs] ||= attr_cache do |type|
+                {
+                  'graphql.type.name' => type.graphql_name,
+                  'graphql.lazy' => true
+                }
+              end
+              resolve_type_lazy_attr_cache[data[:type]]
             when 'execute_query'
+              attributes = {
+                'graphql.document' => data[:query].query_string,
+                'graphql.operation.type' => data[:query].selected_operation.operation_type
+              }
               attributes['graphql.operation.name'] = data[:query].selected_operation_name if data[:query].selected_operation_name
-              attributes['graphql.operation.type'] = data[:query].selected_operation.operation_type
-              attributes['graphql.document'] = data[:query].query_string
+              attributes
+            else
+              {}
+            end
+          end
+
+          def attr_cache
+            cache_h = Hash.new do |h, k|
+              h[k] = yield(k)
             end
-            attributes
+            cache_h.compare_by_identity
+            cache_h
           end
         end
       end