fix: strict rdkafka support to v0.14

open-telemetry · Jan 7, 2025 · 566411e · 566411e
1 parent 0cfc9d0
commit 566411e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 9 deletions.
diff --git a/instrumentation/rdkafka/Appraisals b/instrumentation/rdkafka/Appraisals
@@ -4,12 +4,10 @@
 #
 # SPDX-License-Identifier: Apache-2.0
 
-appraise 'rdkafka-0.12.x' do
-  gem 'rdkafka', '~> 0.12.0'
-end
-
-appraise 'rdkafka-0.13.x' do
-  gem 'rdkafka', '~> 0.13.0'
+%w[0.12.0 0.13.0 0.14.0].each do |version|
+  appraise "rdkafka-#{version}" do
+    gem 'rdkafka', "~> #{version}"
+  end
 end
 
 appraise 'rdkafka-latest' do

diff --git a/instrumentation/rdkafka/lib/opentelemetry/instrumentation/rdkafka/instrumentation.rb b/instrumentation/rdkafka/lib/opentelemetry/instrumentation/rdkafka/instrumentation.rb
@@ -9,10 +9,8 @@ module Instrumentation
     module Rdkafka
       # The Instrumentation class contains logic to detect and install the Rdkafka instrumentation
       class Instrumentation < OpenTelemetry::Instrumentation::Base
-        MINIMUM_VERSION = Gem::Version.new('0.10.0')
-
         compatible do
-          Gem::Version.new(::Rdkafka::VERSION) >= MINIMUM_VERSION
+          Gem::Requirement.new('>= 0.10.0', '< 0.15.0').satisfied_by?(::Rdkafka::VERSION)
         end
 
         install do |_config|