-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: grpc endpoint #4051
fix: grpc endpoint #4051
Conversation
I suspect that many examples will have the same issue. If you agree, I can review and update other examples as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes sense since otel-collector
in the latest version:
The otlpreceiver now uses localhost by default instead of 0.0.0.0
Care to fix the README as well?
Please also update |
41458cb
to
4854d84
Compare
Description
Hello!
Your tutorial was very helpful for me. I found that the new version of the collector no longer uses 0.0.0.0 as the default, so in this MR, I fixed it. You can find more information about the update at: https://github.com/open-telemetry/opentelemetry-collector/releases/tag/v0.104.0
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Checklist: