Skip to content

Commit

Permalink
Fix typing for api instrumentors
Browse files Browse the repository at this point in the history
  • Loading branch information
@xrmx
xrmx committed Jan 16, 2025
1 parent a7d395e commit e9e4ddc
Showing 1 changed file with 21 additions and 19 deletions.
40 changes: 21 additions & 19 deletions opentelemetry-api/src/opentelemetry/metrics/_internal/__init__.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,9 @@ def __init__(
self._name = name
self._version = version
self._schema_url = schema_url
self._instrument_ids: Dict[str, str] = {}
self._instrument_ids: Dict[
str, Optional[MetricsInstrumentAdvisory]
] = {}
self._instrument_ids_lock = Lock()

@property
Expand Down Expand Up @@ -277,7 +279,7 @@ def create_counter(
name: str,
unit: str = "",
description: str = "",
advisory: Optional[MetricsInstrumentAdvisory] = None,
advisory: None = None,
) -> Counter:
"""Creates a `Counter` instrument
Expand All @@ -294,7 +296,7 @@ def create_up_down_counter(
name: str,
unit: str = "",
description: str = "",
advisory: Optional[MetricsInstrumentAdvisory] = None,
advisory: None = None,
) -> UpDownCounter:
"""Creates an `UpDownCounter` instrument
Expand All @@ -312,7 +314,7 @@ def create_observable_counter(
callbacks: Optional[Sequence[CallbackT]] = None,
unit: str = "",
description: str = "",
advisory: Optional[MetricsInstrumentAdvisory] = None,
advisory: None = None,
) -> ObservableCounter:
"""Creates an `ObservableCounter` instrument
Expand Down Expand Up @@ -425,7 +427,7 @@ def create_gauge( # type: ignore # pylint: disable=no-self-use
name: str,
unit: str = "",
description: str = "",
advisory: Optional[MetricsInstrumentAdvisory] = None,
advisory: None = None,
) -> Gauge:
"""Creates a ``Gauge`` instrument
Expand All @@ -444,7 +446,7 @@ def create_observable_gauge(
callbacks: Optional[Sequence[CallbackT]] = None,
unit: str = "",
description: str = "",
advisory: Optional[MetricsInstrumentAdvisory] = None,
advisory: None = None,
) -> ObservableGauge:
"""Creates an `ObservableGauge` instrument
Expand All @@ -465,7 +467,7 @@ def create_observable_up_down_counter(
callbacks: Optional[Sequence[CallbackT]] = None,
unit: str = "",
description: str = "",
advisory: Optional[MetricsInstrumentAdvisory] = None,
advisory: None = None,
) -> ObservableUpDownCounter:
"""Creates an `ObservableUpDownCounter` instrument
Expand Down Expand Up @@ -514,7 +516,7 @@ def create_counter(
name: str,
unit: str = "",
description: str = "",
advisory: Optional[MetricsInstrumentAdvisory] = None,
advisory: None = None,
) -> Counter:
with self._lock:
if self._real_meter:
Expand All @@ -528,7 +530,7 @@ def create_up_down_counter(
name: str,
unit: str = "",
description: str = "",
advisory: Optional[MetricsInstrumentAdvisory] = None,
advisory: None = None,
) -> UpDownCounter:
with self._lock:
if self._real_meter:
Expand All @@ -545,7 +547,7 @@ def create_observable_counter(
callbacks: Optional[Sequence[CallbackT]] = None,
unit: str = "",
description: str = "",
advisory: Optional[MetricsInstrumentAdvisory] = None,
advisory: None = None,
) -> ObservableCounter:
with self._lock:
if self._real_meter:
Expand Down Expand Up @@ -579,7 +581,7 @@ def create_gauge(
name: str,
unit: str = "",
description: str = "",
advisory: Optional[MetricsInstrumentAdvisory] = None,
advisory: None = None,
) -> Gauge:
with self._lock:
if self._real_meter:
Expand All @@ -594,7 +596,7 @@ def create_observable_gauge(
callbacks: Optional[Sequence[CallbackT]] = None,
unit: str = "",
description: str = "",
advisory: Optional[MetricsInstrumentAdvisory] = None,
advisory: None = None,
) -> ObservableGauge:
with self._lock:
if self._real_meter:
Expand All @@ -613,7 +615,7 @@ def create_observable_up_down_counter(
callbacks: Optional[Sequence[CallbackT]] = None,
unit: str = "",
description: str = "",
advisory: Optional[MetricsInstrumentAdvisory] = None,
advisory: None = None,
) -> ObservableUpDownCounter:
with self._lock:
if self._real_meter:
Expand Down Expand Up @@ -641,7 +643,7 @@ def create_counter(
name: str,
unit: str = "",
description: str = "",
advisory: Optional[MetricsInstrumentAdvisory] = None,
advisory: None = None,
) -> Counter:
"""Returns a no-op Counter."""
_, status = self._register_instrument(
Expand All @@ -665,7 +667,7 @@ def create_gauge(
name: str,
unit: str = "",
description: str = "",
advisory: Optional[MetricsInstrumentAdvisory] = None,
advisory: None = None,
) -> Gauge:
"""Returns a no-op Gauge."""
_, status = self._register_instrument(
Expand All @@ -689,7 +691,7 @@ def create_up_down_counter(
name: str,
unit: str = "",
description: str = "",
advisory: Optional[MetricsInstrumentAdvisory] = None,
advisory: None = None,
) -> UpDownCounter:
"""Returns a no-op UpDownCounter."""
_, status = self._register_instrument(
Expand All @@ -714,7 +716,7 @@ def create_observable_counter(
callbacks: Optional[Sequence[CallbackT]] = None,
unit: str = "",
description: str = "",
advisory: Optional[MetricsInstrumentAdvisory] = None,
advisory: None = None,
) -> ObservableCounter:
"""Returns a no-op ObservableCounter."""
_, status = self._register_instrument(
Expand Down Expand Up @@ -770,7 +772,7 @@ def create_observable_gauge(
callbacks: Optional[Sequence[CallbackT]] = None,
unit: str = "",
description: str = "",
advisory: Optional[MetricsInstrumentAdvisory] = None,
advisory: None = None,
) -> ObservableGauge:
"""Returns a no-op ObservableGauge."""
_, status = self._register_instrument(
Expand Down Expand Up @@ -800,7 +802,7 @@ def create_observable_up_down_counter(
callbacks: Optional[Sequence[CallbackT]] = None,
unit: str = "",
description: str = "",
advisory: Optional[MetricsInstrumentAdvisory] = None,
advisory: None = None,
) -> ObservableUpDownCounter:
"""Returns a no-op ObservableUpDownCounter."""
_, status = self._register_instrument(
Expand Down

0 comments on commit e9e4ddc

Please sign in to comment.