Fix uv setup when using tox #3282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: emdneto <[email protected]>
Signed-off-by: emdneto <[email protected]>
xrmx
approved these changes
Feb 21, 2025
Signed-off-by: emdneto <[email protected]>
emdneto
commented
Feb 21, 2025
Signed-off-by: emdneto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are using
tox-uv, it is reading the uv configuration underpyproject.tomlfor sources and workspaces (as expected), and this is causing some tests to fail because uv and tox deps are conflicting (e.g., tox is installing opentelemetry-api@CORE_REPO_SHA and uv is telling to install opentelemetry-api@main. I explained a bit about that behavior hereThis change is to make tox ignore whatever is defined in [tool.uv.sources] configuration
Note: I tried
UV_NO_CONFIGenv var but didn't work because workspaces/sources are related to pyproject scopePR in -core to show it works for cross-reference SHA: open-telemetry/opentelemetry-python#4445