Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove root module #212

Closed
wants to merge 3 commits into from
Closed

Remove root module #212

wants to merge 3 commits into from

Conversation

dmathieu
Copy link
Member

This is an alternative solution for the tidy issue in #193

Related: #211

@dmathieu dmathieu marked this pull request as ready for review November 28, 2024 09:58
@dmathieu dmathieu requested a review from a team as a code owner November 28, 2024 09:58
@florianl florianl mentioned this pull request Nov 28, 2024
Merged
pellared
pellared reviewed Nov 28, 2024
View reviewed changes
Copy link
Member

@pellared pellared left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

versions.yaml needs to be updated. Otherwise, the release will fail.
It would be good to run $(MULTIMOD) verify in CI.

@pellared pellared mentioned this pull request Nov 28, 2024
Merged
@pellared
Copy link
Member

pellared commented Nov 28, 2024 •
edited
Loading

I just realized that without the root module the v* tags will not be created and pushed by the release automation. We would need to update the push-tags Make target to publish them or add a manual step to create these tags and push them.

@pellared
Copy link
Member

I just want to additionally mention that IMO this it not a blocker for:

@dmathieu
Copy link
Member Author

Closing per #211

@dmathieu dmathieu closed this Nov 28, 2024
@dmathieu dmathieu deleted the remove-root-module branch November 28, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pellared pellared pellared left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmathieu @pellared