fix: apache instrumentation with lifecycle #3548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@L3o-pold thank you for your contribution! Could you add a changelog entry? Running |
L3o-pold
force-pushed
the
fix/apache-instrumentation-with-lifecycle
branch
from
f4a2bfb to
bbe81b4
Compare
|
@swiatekm done |
yuriolisa
reviewed
Dec 16, 2024
| component: auto-instrumentation | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: Apache instrumentation sidecar needs to remove lifecycle as it's not supported |
There was a problem hiding this comment.
Please replace the sentence with a description of what you are fixing instead of the reason why you are doing it.
yuriolisa
approved these changes
Dec 16, 2024
L3o-pold
force-pushed
the
fix/apache-instrumentation-with-lifecycle
branch
from
bbe81b4 to
3f58ea9
Compare
swiatekm
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Apache instrumentation sidecar needs to remove lifecycle as it's not supported, same as #2366
fix #3547