Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Python SDK version #1035

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Display Python SDK version #1035

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1cabe6
Fix display of opentelemetry-sdk for Python
ocelotl Dec 7, 2023
e8fe7bd
Address comments
ocelotl Dec 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 18 additions & 8 deletions .github/workflows/release-layer-python.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,30 +14,40 @@ jobs:
build-layer:
runs-on: ubuntu-latest
outputs:
PYTHON_SDK_VERSION: ${{ steps.save-python-sdk-version.outputs.PYTHON_SDK_VERSION}}
PYTHON_OPENTELEMETRY_SDK_VERSION: ${{ steps.save-python-sdk-version.outputs.PYTHON_OPENTELEMETRY_SDK_VERSION}}
steps:
- uses: actions/checkout@v4

- uses: actions/setup-python@v4
with:
python-version: '3.9'

- name: Get PYTHON_OPENTELEMETRY_SDK_VERSION
run: |
cd python/src
echo "PYTHON_OPENTELEMETRY_SDK_VERSION=$(head -n1 otel/otel_sdk/requirements.txt)" >> $GITHUB_ENV
shell: bash

- name: Display PYTHON_OPENTELEMETRY_SDK_VERSION
run: echo "PYTHON_OPENTELEMETRY_SDK_VERSION=${{ env.PYTHON_OPENTELEMETRY_SDK_VERSION }}"
shell: bash

- name: Save Python SDK Version
id: save-python-sdk-version
run: |
echo "PYTHON_OPENTELEMETRY_SDK_VERSION=$PYTHON_OPENTELEMETRY_SDK_VERSION" >> $GITHUB_OUTPUT
tylerbenson marked this conversation as resolved.
Show resolved Hide resolved

- name: Build
run: |
cd python/src
PYTHON_SDK_VERSION=$(./build.sh 2>&1 > /dev/null | sed -n "s/opentelemetry-sdk==\(.*\)/\1/p")
./build.sh
shell: bash

- name: Show directory contents
run: |
ls -al
working-directory: python/src/build

- name: Save Python SDK Version
id: save-python-sdk-version
run: |
echo "PYTHON_SDK_VERSION=$PYTHON_SDK_VERSION" >> $GITHUB_OUTPUT

- uses: actions/upload-artifact@v3
name: Save assembled layer to build
with:
Expand Down Expand Up @@ -69,7 +79,7 @@ jobs:
with:
artifact-name: opentelemetry-python-layer.zip
layer-name: opentelemetry-python
component-version: ${{needs.build-layer.outputs.PYTHON_SDK_VERSION}}
component-version: ${{needs.build-layer.outputs.PYTHON_OPENTELEMETRY_SDK_VERSION}}
# architecture:
release-group: prod
aws_region: ${{ matrix.aws_region }}
Expand Down
1 change: 0 additions & 1 deletion python/src/otel/otel_sdk/requirements-nodeps.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,3 @@ opentelemetry-instrumentation-sqlite3==0.42b0
opentelemetry-instrumentation-starlette==0.42b0
opentelemetry-instrumentation-tornado==0.42b0
opentelemetry-instrumentation-wsgi==0.42b0

tylerbenson marked this conversation as resolved.
Show resolved Hide resolved
1 change: 1 addition & 0 deletions python/src/otel/otel_sdk/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
opentelemetry-sdk==1.21.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependabot should update this with every new release.

opentelemetry-exporter-otlp-proto-http==1.21.0
opentelemetry-distro==0.42b0
opentelemetry-instrumentation-aws-lambda==0.42b0
Loading