feat(core)!: remove deprecated samplers #5316
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pichlermarc
added
pkg:core
target:next-major-release
pichlermarc
force-pushed
the
feat/remove-deprecated-samplers
branch
from
ce60103 to
0b68000
Compare
pichlermarc
changed the title
pichlermarc
force-pushed
the
feat/remove-deprecated-samplers
branch
from
0b68000 to
c88eb92
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5316 +/- ##
==========================================
+ Coverage 94.56% 94.58% +0.01%
==========================================
Files 322 318 -4
Lines 8132 8067 -65
Branches 1715 1700 -15
==========================================
- Hits 7690 7630 -60
+ Misses 442 437 -5 |
trentm
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
And from some spelunking, this fixtures/test-package/... dir could have been removed back in #2081 (3y ago).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Removing deprecated samplers from
@opentelemetry/corethat were moved to@opentelemetry/sdk-trace-basea long time ago (#3088)Part of #5172
Type of change